Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try out new spellcheck #209

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

try out new spellcheck #209

wants to merge 9 commits into from

Conversation

StefanThoma
Copy link
Collaborator

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@StefanThoma StefanThoma linked an issue Aug 8, 2024 that may be closed by this pull request
Explore the use of Github marketplace spellcheck action #207
Open
@StefanThoma
Copy link
Collaborator Author

There seems to be some problems with encoding or something:

Misspelled words:
posts/2024-03-01_rhino_shiny_app_validation/rhino_shiny_app_validation.qmd: html>body>p

Taşl
Ży

Misspelled words:
posts/2024-03-04_inside_the__phar.../inside_the__pharmaverse.qmd: html>body>ul>li>p

PHUSE’s

@StefanThoma
Copy link
Collaborator Author

Note to myself, as I won't be able to do it now:

Try to:
Run original spellcheck after running:

# Find all .qmd files in the current directory and subdirectories
find . -type f -name "*.qmd" | while read -r file; do
  # Remove Markdown-style links [text](URL)
  sed -i.bak -E 's/\[([^\]]+)\]\([^)]+\)//g' "$file"

  # Remove standalone URLs like <http://example.com>
  sed -i.bak -E 's/<([^>]+)>//g' "$file"
  
  # Optionally, remove empty brackets [] that may be left behind
  sed -i.bak -E 's/\[\]//g' "$file"

  # Clean up backup files
  rm "${file}.bak"
done

The bash command should remove all links from all qmd files.

@manciniedoardo
Copy link
Collaborator

Ideas from today's call:

  • could we have global and local wordlists? global would have common words like PHUSE and ADaM while local would have anything like links sections which we woulfn't want to be used inn other posts.
  • this could be generated by the create_blogpost helper?

@StefanThoma to review

@manciniedoardo
Copy link
Collaborator

Update: leave as pending for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore the use of Github marketplace spellcheck action
2 participants
@StefanThoma @manciniedoardo